fix: only log response body when include_resp_body is enabled#12599
Merged
Conversation
LiteSun
marked this pull request as ready for review
September 8, 2025 08:28
dosubot
Bot
added
size:L
AlinsRan
previously approved these changes
Sep 8, 2025
nic-6443
reviewed
Sep 9, 2025
nic-6443
approved these changes
Sep 9, 2025
AlinsRan
approved these changes
Sep 9, 2025
membphis
approved these changes
Sep 9, 2025
jizhuozhi
pushed a commit
to jizhuozhi/apisix
that referenced
this pull request
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where, when both file-logger and http-logger plugins are configured on the same route, enabling include_resp_body in file-logger would also cause http-logger to log the response body, even if include_resp_body was disabled for http-logger.
Which issue(s) this PR fixes:
fix #12537
Checklist