fix(ai-proxy): catch malformed override endpoint in schema validation#12563
Merged
Conversation
dosubot
Bot
added
size:M
nic-6443
approved these changes
Aug 29, 2025
AlinsRan
approved these changes
Aug 29, 2025
bzp2010
reviewed
Aug 29, 2025
| local type = type | ||
|
|
||
| local priority_balancer = require("apisix.balancer.priority") | ||
| local endpoint_regex = "^(https?)://([^:/]+):?(%d*)/?.*$" |
Contributor
There was a problem hiding this comment.
Are you sure this is correct?
- The
/appears to be unescaped. If the Lua string"xxx"can avoid this issue, please disregard. %dseems to cause backtracking and result in a failed match? Whereas\dmatches correctly.
I'm using https://regex101.com PCRE2 mode to check it.
Contributor
Author
There was a problem hiding this comment.
I guess its parsed differently in the website vs the lua code.
- is no issue. its parsed correctly as can be confirmed by tests.
- It does match otherwise tests would be failing.
bzp2010
approved these changes
Aug 29, 2025
jizhuozhi
pushed a commit
to jizhuozhi/apisix
that referenced
this pull request
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when invalid url is passed in override endpoint like "http//localhost:8080" (here : is missing). The ai configuration is still accepted.
But later error comes in user request path and user gets 500
This PR adds endpoint validation during schema check.