fix(plugin/redirect): ensure redirect when scheme is not https#12561
Merged
SkyeYoung merged 2 commits intoSep 19, 2025
Merged
Conversation
SkyeYoung
marked this pull request as ready for review
August 29, 2025 02:43
dosubot
Bot
added
size:S
5 tasks
bzp2010
approved these changes
Sep 8, 2025
nic-6443
approved these changes
Sep 15, 2025
membphis
approved these changes
Sep 18, 2025
jizhuozhi
pushed a commit
to jizhuozhi/apisix
that referenced
this pull request
Oct 18, 2025
…che#12561) * fix(plugin/redirect): ensure redirect when scheme is not `https` * test: add redirect when not https case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the original logic, using values like
X-Forwarded-Proto: any_valuecould bypass the redirect.Obviously, this logic is incorrect, so in this PR it's adjusted to redirect when
X-Forwarded-Protois nothttps.part of #12500
Which issue(s) this PR fixes:
Fixes #
Checklist