fix: docker entrypoint remove stream_worker_events.sock if exists#12546
Merged
Conversation
dosubot
Bot
added
size:XS
bzp2010
requested review from
AlinsRan,
Baoyuantop,
Revolyssup,
SkyeYoung,
juzhiyuan,
membphis and
nic-6443
August 23, 2025 08:57
moonming
reviewed
Aug 23, 2025
moonming
left a comment
moonming
left a comment
Member
There was a problem hiding this comment.
The Docker image of Apache APISIX has been switched to Ubuntu. Does the debain file still need to be maintained?
Contributor
Author
|
I don't think we've made that decision yet. If we plan to do so, we need a statement indicating that we are switching from Debian to Ubuntu. In any case, this change is for the dev image, so it should not be controversial. |
Baoyuantop
approved these changes
Aug 26, 2025
membphis
approved these changes
Aug 26, 2025
SkyeYoung
approved these changes
Aug 27, 2025
|
I want to know when this change will be released? I killed the docker instance of APISIX, then starts the container(simulates host power failure). The APISIX container failed to start with many /usr/local/openresty//luajit/bin/luajit ./apisix/cli/apisix.lua init
/usr/local/openresty//luajit/bin/luajit ./apisix/cli/apisix.lua init_etcd
trying to initialize the data of etcd
2025/09/25 15:36:40 [emerg] 1#1: bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
nginx: [emerg] bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
2025/09/25 15:36:40 [emerg] 1#1: bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
nginx: [emerg] bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
2025/09/25 15:36:40 [emerg] 1#1: bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
nginx: [emerg] bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
2025/09/25 15:36:40 [emerg] 1#1: bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
nginx: [emerg] bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
2025/09/25 15:36:40 [emerg] 1#1: bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
nginx: [emerg] bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
2025/09/25 15:36:40 [emerg] 1#1: still could not bind()
nginx: [emerg] still could not bind(The issue will be fixed when I replace image |
jizhuozhi
pushed a commit
to jizhuozhi/apisix
that referenced
this pull request
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the container exits abnormally, Nginx cannot properly clean up the unix domain socket files it is listening on. When the container is restarted, the startup will fail because the files still exist, preventing the container from starting.
Therefore, we check and delete the files in the entrypoint script of the Docker container. This includes the conf server and event broker.
However, this overlooks the event broker UDS file used by the stream subsystem, so when using TCP/UDP proxies, startup may still fail.
This PR fixes the issue by checking whether the file exists and deleting it if it does.
DEV image
Checklist