chore: remove redundant profile.apisix_home assignment in start#12529
Merged
Conversation
dosubot
Bot
added
size:XS
SkyeYoung
approved these changes
Aug 18, 2025
SkyeYoung
changed the title
profile.apisix_home assignment in start
SkyeYoung
requested review from
Baoyuantop,
bzp2010,
Copilot,
juzhiyuan,
membphis and
nic-chen
August 18, 2025 03:31
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant code that sets profile.apisix_home in the start function, since the same assignment is already performed in the cleanup function that is called immediately before it.
- Removes duplicate
profile.apisix_homeassignment from thestartfunction
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
membphis
approved these changes
Aug 18, 2025
nic-chen
approved these changes
Aug 18, 2025
jizhuozhi
pushed a commit
to jizhuozhi/apisix
that referenced
this pull request
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Which issue(s) this PR fixes:
Fixes #12528
Checklist