fix(grpc-web): missing trailers when empty resp body#12490
Merged
SkyeYoung merged 26 commits intoAug 12, 2025
Conversation
bzp2010
changed the title
bzp2010
marked this pull request as ready for review
August 5, 2025 12:59
dosubot
Bot
added
size:XXL
bzp2010
commented
Aug 5, 2025
bzp2010
force-pushed
the
bzp/fix-grpc-web-missing-trailers
branch
from
August 5, 2025 16:43
237c47a to
1a5a156
Compare
Member
|
Need to fix the CI. |
Contributor
|
waiting on CI pass for review |
bzp2010
requested review from
AlinsRan,
Revolyssup,
SkyeYoung,
membphis and
nic-6443
August 12, 2025 02:38
Revolyssup
approved these changes
Aug 12, 2025
SkyeYoung
approved these changes
Aug 12, 2025
SkyeYoung
left a comment
SkyeYoung
left a comment
Member
There was a problem hiding this comment.
Thanks for the detailed comments, LGTM
nic-6443
approved these changes
Aug 12, 2025
jizhuozhi
pushed a commit
to jizhuozhi/apisix
that referenced
this pull request
Oct 18, 2025
shreemaan-abhishek
pushed a commit
to shreemaan-abhishek/apisix
that referenced
this pull request
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12202
The problem that this PR solves is fully described in the comments of the code.
Checklist