fix: batch processor cache not working when configure plugin in service#12474
Merged
Merged
Conversation
dosubot
Bot
added
the
size:M
Revolyssup
approved these changes
Jul 30, 2025
nic-chen
approved these changes
Jul 30, 2025
membphis
approved these changes
Jul 31, 2025
jizhuozhi
pushed a commit
to jizhuozhi/apisix
that referenced
this pull request
Oct 18, 2025
…ce (apache#12474) Signed-off-by: Nic <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When merging the configurations of service and route, APISIX will first perform a deepcopy on the configuration of the service.
apisix/apisix/plugin.lua
Lines 585 to 586 in e3e5a99
This results in each route associated with this service getting an independent plugin configuration table, causing the cache in
batch-processor-manager.luathat is based on table memory addresses as keys to not work properly.Note
After this fix, every logger plugin that integrated with
batch-processor-manager.luacan share the same batch processor object as long as the plugin configuration is identical. For example, with kafka-logger, even if the exact same kafka-logger plugin is configured on different services, the batch processor object and kafka producer will be the same and will not be created multiple times.Which issue(s) this PR fixes:
Fixes #
Checklist