fix(opentelemetry): remove plugin attr set_ngx_var#12411
Merged
Conversation
Baoyuantop
marked this pull request as ready for review
July 11, 2025 09:32
Baoyuantop
requested review from
AlinsRan,
Revolyssup,
kayx23,
membphis and
nic-6443
July 11, 2025 09:33
membphis
approved these changes
Jul 14, 2025
nic-6443
approved these changes
Jul 15, 2025
AlinsRan
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We changed the attribute of the Opentelemetry plugin to metadata in PR #11940. After that, users can set the
set_ngx_varproperty in metadata. However, the generated template file still relies on theset_ngx_varproperty from the plugin attribute to predefine variables https://github.com/apache/apisix/blob/master/apisix/cli/ops.lua#L553-L556, which will confuse users. This PR removes this judgment and allows this property to be controlled in metadata only.Which issue(s) this PR fixes:
Fixes #12402
Checklist