Skip to content

revert: fix: forward-auth request body too large#12404

Merged
Revolyssup merged 1 commit into
apache:masterfrom
Revolyssup:revolyssup/forward-auth-fix-revert
Jul 7, 2025
Merged

revert: fix: forward-auth request body too large#12404
Revolyssup merged 1 commit into
apache:masterfrom
Revolyssup:revolyssup/forward-auth-fix-revert

Conversation

@Revolyssup

@Revolyssup Revolyssup commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

Description

This PR https://github.com/apache/apisix/pull/10589/files, introduced a bug due to which the request body is emptied after being read by the auth service and the upstream doesn't receive the request body. Therefore, this PR needs to be reverted.

The new solution after this revert is accepted will be:
Do not need to pass the whole request body to the auth service and extract data from body into headers and then forward to the auth service. The headers to be extracted will be specified with a new field: extra_headers

Fixes #11200

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jul 7, 2025
@nic-6443
nic-6443 requested review from bzp2010 and membphis July 7, 2025 06:36

@membphis membphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Revolyssup
Revolyssup merged commit 138d403 into apache:master Jul 7, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: After the forward-auth verification is passed, the upstream cannot obtain the request body (payload) with 504 Timeout

4 participants