fix: zipkin trace_id and span_id format in ngx_var#12403
Merged
Conversation
Baoyuantop
requested review from
AlinsRan,
Revolyssup,
bzp2010,
membphis,
moonming and
nic-6443
July 9, 2025 06:39
nic-6443
approved these changes
Jul 9, 2025
membphis
approved these changes
Jul 10, 2025
AlinsRan
approved these changes
Jul 11, 2025
shreemaan-abhishek
pushed a commit
to shreemaan-abhishek/apisix
that referenced
this pull request
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to Zipkin's documentation, the TraceID passed via HTTP headers uses lowercase hexadecimal encoding, not binary data. For example, the B3 specification states that the value of the X-B3-TraceId header is 16 or 32 lowercase hexadecimal characters (corresponding to 64 or 128 bits, respectively)
We need to convert the trace_id and span_id formats stored in the variables.
Which issue(s) this PR fixes:
Fixes #12271
Checklist