fix: get_keys only return first 1024 items in shared dict by default#12380
Merged
Conversation
Signed-off-by: Nic <[email protected]>
dosubot
Bot
added
size:XS
nic-6443
changed the title
get_keys only return first 1024 items in shared dict by default
Contributor
|
I found a similar call https://github.com/apache/apisix/blob/master/apisix/init.lua#L907, do we need to handle it here? |
moonming
approved these changes
Jun 26, 2025
membphis
approved these changes
Jun 26, 2025
Member
Author
@Baoyuantop The data stored in this place is the state of each worker. I think there will not be more than 1024 workers for any apisix instance, so it does not need to be changed. |
Baoyuantop
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
From OpenResty Doc:
We should return complete data in the
/v1/discovery/{service}/dumpcontrol API, otherwise, it will confuse users.Which issue(s) this PR fixes:
Fixes #
Checklist