feat: add apisix dashboard to dev image#12369
Merged
Merged
Conversation
bzp2010
marked this pull request as ready for review
June 23, 2025 10:59
dosubot
Bot
added
size:S
SkyeYoung
reviewed
Jun 23, 2025
| - name: Check out the repo | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Build APISIX Dashboard |
Member
There was a problem hiding this comment.
Should a Makefile command be written for users to build locally themselves?
Contributor
Author
There was a problem hiding this comment.
I don't feel the need. It's not a standard build and development process, and it doesn't seem to make much sense to package an image.
Users should develop through the apisix-dashboard project, not in apisix.
juzhiyuan
approved these changes
Jun 23, 2025
membphis
approved these changes
Jun 24, 2025
nic-6443
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Build the APISIX dashboard and put it into the dev image.
Checklist