fix: add sleep to fix flaky healthcheck cli test#12272
Merged
Merged
Conversation
dosubot
Bot
added
size:XS
bzp2010
approved these changes
May 30, 2025
membphis
approved these changes
May 30, 2025
5 tasks
nic-6443
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to the CLI test introduced in recent standalone healthcheck PR, the CI is failing on master as well making the test flaky.
https://github.com/apache/apisix/actions/runs/15330643322/job/43165226189?pr=12263#step:7:7542
The reason is that /status/ready is being hit in test before all workers can be ready. This PR adds a 2 second sleep to make sure workers are ready.
Checklist