Skip to content

fix(standalone): API-driven mode does not properly handle consumer schema#12256

Merged
AlinsRan merged 13 commits into
apache:masterfrom
AlinsRan:fix/consumer-credential-modifiedIndex
May 30, 2025
Merged

fix(standalone): API-driven mode does not properly handle consumer schema#12256
AlinsRan merged 13 commits into
apache:masterfrom
AlinsRan:fix/consumer-credential-modifiedIndex

Conversation

@AlinsRan

@AlinsRan AlinsRan commented May 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Which issue(s) this PR fixes:

Fixes #12253

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@AlinsRan AlinsRan changed the title fix(standalone): API-driven mode does not properly handle consumer sc… fix(standalone): API-driven mode does not properly handle consumer schema May 26, 2025
AlinsRan
AlinsRan commented May 26, 2025
View reviewed changes
Comment thread apisix/stream/router/ip_port.lua
automatic = true,
item_schema = core.schema.stream_route,
checker = stream_route_checker,
checker = function(item)

@AlinsRan AlinsRan May 26, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer stream_route_checker(item, in_cp): In_cp is only applicable to admin-api.

@AlinsRan
AlinsRan marked this pull request as ready for review May 26, 2025 09:02
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 26, 2025
@dosubot dosubot Bot added the bug Something isn't working label May 26, 2025
nic-6443
nic-6443 reviewed May 27, 2025
View reviewed changes
Comment thread apisix/core/config_yaml.lua
nic-6443
nic-6443 previously approved these changes May 27, 2025
View reviewed changes
bzp2010
bzp2010 reviewed May 29, 2025
View reviewed changes
Comment thread apisix/admin/standalone.lua
Comment thread apisix/schema_def.lua Outdated
@AlinsRan
AlinsRan requested review from bzp2010 and nic-6443 May 29, 2025 10:15
ronething
ronething approved these changes May 30, 2025
View reviewed changes

@ronething ronething left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@AlinsRan
AlinsRan merged commit 9d2d9cf into apache:master May 30, 2025
@AlinsRan
AlinsRan deleted the fix/consumer-credential-modifiedIndex branch May 30, 2025 09:20
laz-xyr pushed a commit to laz-xyr/apisix that referenced this pull request Jun 19, 2025
@AlinsRan
fix(standalone): API-driven mode does not properly handle consumer sc…
f2c0fa7 
…hema (apache#12256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bzp2010 bzp2010 bzp2010 approved these changes
@nic-6443 nic-6443 nic-6443 approved these changes
@ronething ronething ronething approved these changes
@membphis membphis Awaiting requested review from membphis

Assignees

No one assigned

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: API-driven standalone mode does not properly handle consumer schema checks

4 participants

@AlinsRan @bzp2010 @nic-6443 @ronething