feat: add warning for data plane writing to etcd#12241
Merged
Merged
Conversation
LiteSun
marked this pull request as draft
May 23, 2025 04:50
LiteSun
marked this pull request as ready for review
May 25, 2025 23:05
LiteSun
marked this pull request as draft
May 29, 2025 03:59
LiteSun
marked this pull request as ready for review
June 3, 2025 07:32
moonming
previously approved these changes
Jun 9, 2025
nic-6443
reviewed
Jun 9, 2025
|
|
||
|
|
||
|
|
||
| local function block_write_if_data_plane() |
Member
There was a problem hiding this comment.
block is not a good name in here. block is often used to indicate IO blocking, such as: blocking io and non-blocking io. block_write has a significant ambiguity with the actual function of this function. It is recommended to change it to disable, etc.
nic-6443
approved these changes
Jun 10, 2025
moonming
approved these changes
Jun 10, 2025
laz-xyr
pushed a commit
to laz-xyr/apisix
that referenced
this pull request
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When APISIX is running as a data plane, if any ETCD write operations are performed through
core.etcdrelated functions or CLI, warning logs will be printed without blocking the write operations. This functionality will be deprecated in future versions, after which write operations will no longer be allowed.Mailing list: https://lists.apache.org/thread/gfsooqm4cz6cx2sh7htmqgwlml5kggm2
Scope of Impact
ETCD Write Operations Using core.etcd Related Functions
Example usage:
Based on the analysis of the
apisix/core/etcd.luafile, the following functions can perform ETCD write operations:For these functions, warning logs will be printed to inform users that this functionality will be deprecated in future versions, after which write operations will no longer be allowed.
ETCD Write Operations Using CLI Created by core.etcd.new()
Example usage:
After exporting the CLI, referring to the https://github.com/api7/lua-resty-etcd/blob/master/lib/resty/etcd/v3.lua file, the following operations perform ETCD write operations:
For these functions, warning logs will be printed to inform users that this functionality will be deprecated in future versions, after which write operations will no longer be allowed.
Timeline
If there are no strong objections on the mailing list, the plan is as follows:
Checklist