change: delete the server-info plugin #12218
Merged
Merged
Conversation
…s from the codebase
LiteSun
changed the title
server-info plugin and its related configuration…server-info plugin
LiteSun
marked this pull request as ready for review
May 16, 2025 00:28
dosubot
Bot
added
size:XL
nic-6443
approved these changes
May 16, 2025
AlinsRan
changed the title
server-info plugin server-info plugin
AlinsRan
approved these changes
May 16, 2025
ronething
approved these changes
May 16, 2025
membphis
approved these changes
May 16, 2025
Contributor
@LiteSun @nic-6443 @AlinsRan @ronething @membphis The author and all who approved this PR, I have questions:Where is the discussion on this BREAK CHANGE?Why is such a break change being merged without public discussion?The plugin does not contain a security vulnerability and we are not going to release a patch for it, so why perform such an urgent change operation?When you merge this break change, what is the equivalent alternative to this plugin what is it?If there are no alternatives and there is no advance notice of any deprecation plan, why did you just merge this PR?This change isn't urgent at all, and we have plenty of time before the next release, which should have been handled in a better way! Clearly documenting the behavior and risks of the plugin, and telling users what's going on here from a technical perspective would all help to better address the issue. If it needs to be removed, start by initiating a change to the documentation to mark it as “Deprecated and about to be removed”, after which you can modify it to not enable by default and print a log to remind users not to use it anymore.Is it acceptable to remove a plugin so easily? Basically you're telling developers that there are no rules to follow and you can make any break change you want, even if that rule is clearly documented in the PR checklist. There is no reason whatsoever to support this non-backwards compatible PR being merged so hastily and quickly.I believe that we need to revert this commit and then complete the process in a better way. |
laz-xyr
pushed a commit
to laz-xyr/apisix
that referenced
this pull request
Jun 19, 2025
…s from the codebase (apache#12218)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The server-info plugin in Apache APISIX periodically reports basic server information to etcd. When a large number of APISIX instances start simultaneously, these periodic writes can lead to increased load on etcd. If etcd is not adequately provisioned or configured to handle this load, it may become overwhelmed, potentially causing APISIX startup failures. 
Which issue(s) this PR fixes:
Checklist