fix: only parse and validate apisix.yaml in cli when startup#12216
Merged
nic-6443 merged 2 commits intoMay 23, 2025
Conversation
dosubot
Bot
added
size:XS
Signed-off-by: Nic <[email protected]>
nic-6443
force-pushed
the
nic/avoid-parse-apisix-yaml-duplicate
branch
from
May 15, 2025 08:01
958312f to
b4a4c34
Compare
Signed-off-by: Nic <[email protected]>
membphis
approved these changes
May 19, 2025
moonming
approved these changes
May 21, 2025
bzp2010
reviewed
May 22, 2025
nic-chen
approved these changes
May 22, 2025
bzp2010
approved these changes
May 22, 2025
laz-xyr
pushed a commit
to laz-xyr/apisix
that referenced
this pull request
Jun 19, 2025
…12216) Signed-off-by: Nic <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of the
read_yaml_conffunction is to readconfig.yaml, but it also parses and validatesapisix.yaml. This validation only needs to be performed when the CLI module starts, and there is no need to repeatedly parse and validate apisix.yaml during runtime when try to getconfig.yaml:apisix/apisix/core/config_local.lua
Line 61 in 958312f
Which issue(s) this PR fixes:
Fixes #
Checklist