feat: support health checker for stream subsystem#12180
Conversation
Signed-off-by: Nic <[email protected]>
dosubot
Bot
added
size:L
Signed-off-by: Nic <[email protected]>
Signed-off-by: Nic <[email protected]>
| BEGIN { | ||
| if ($ENV{TEST_EVENTS_MODULE} ne "lua-resty-events") { | ||
| $SkipReason = "Only for lua-resty-events events module"; | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this necessary? If lua-resty-worker-event is used, events can't cross subsystems?
There was a problem hiding this comment.
For lua-resty-events, a second request need to be initiated to trigger the passive health check. Ref:
.For lua-resty-worker-events, when I add second request the test case is timing out, So the test case will be a litlte different based on which library is used. So I pinned the test to only lua-resty events.
There was a problem hiding this comment.
Do we need additional test cases to make sure it works? As I understand it, the current use cases with special handling can also override the lua-resty-worker-event library? 🤔
There was a problem hiding this comment.
lua-resty-worker-event case requires a little different handling in test. Okay I will separate these into two tests.
Co-authored-by: Zeping Bai <[email protected]>
…nto nic/stream-healthcheck
dosubot
Bot
added
size:XL
5 participants
Description
support health checker for stream subsystem
Which issue(s) this PR fixes:
Fixes #
Checklist