refactor: mcp server framework implementation#12168
Merged
Merged
Conversation
dosubot
Bot
added
size:XL
bzp2010
marked this pull request as draft
April 22, 2025 04:59
nic-6443
reviewed
Apr 22, 2025
bzp2010
requested review from
Revolyssup,
SkyeYoung,
juzhiyuan,
membphis and
shreemaan-abhishek
May 28, 2025 06:03
bzp2010
marked this pull request as ready for review
May 28, 2025 06:03
bzp2010
changed the title
membphis
previously approved these changes
May 28, 2025
membphis
left a comment
membphis
left a comment
Member
There was a problem hiding this comment.
LGTM
and pls don't forget to add the doc later, easy to enjoy it for APISIX users
Revolyssup
previously approved these changes
May 29, 2025
Revolyssup
left a comment
Revolyssup
left a comment
Contributor
There was a problem hiding this comment.
The CI is failing but I think its a flaky test. failing on master as well. can be dealt separately.
AlinsRan
reviewed
May 29, 2025
AlinsRan
previously approved these changes
May 30, 2025
Contributor
Author
|
CLI test error fixed by #12272, ignore it for now. PTAL, @nic-6443 @Revolyssup @AlinsRan cc @membphis |
AlinsRan
approved these changes
May 30, 2025
membphis
approved these changes
Jun 4, 2025
SkyeYoung
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactoring the mcp server as a separate module will allow it to support generic scenarios other than mcp-bridge. Next part of #12151
This PR is part of a set of patches that attempt to incrementally improve and enhance the mcp server implementation. Among other things, the mcp-bridge implementation has been replaced with a new framework, and its tests have not been modified, so this proves that nothing has been broken.
Indeed, documentation and tests are not included in this PR because the framework implementation is not complete, and by splitting the whole effort into multiple parts I hope to improve it in quick small steps.
Checklist