Hi @shreemaan-abhishek!
I'm trying to add these attributes based on your PR - could you help me out with tests? I'm a complete newbie in Lua/Perl but we're using APISIX for our Java project and really need this functionality 😅

Hi @MariaLapovska, are you currently experiencing any difficulties? Please describe in more detail so that others can help.

@Baoyuantop I have added max_resp_body_bytes and max_req_body_bytes attributes for http-logger plugin (to be able to limit max request/response body size logged), following the example and reusing the logic that @shreemaan-abhishek has already implemented in this PR.
I am a Java dev, so I don't have enough expertise to write tests for this feature. Would it be possible for anyone to help me out with adding tests for logging large body via http-logger, same as the existing tests for kafka-logger?

Hi @MariaLapovska, we can create an issue detailing this requirement and ensure that the change is justified through community discussion

Hi @Baoyuantop ! I added feature request here - #12130

@MariaLapovska if you spend a little time reading the tests you will understand that they are very simple. Most of the test cases consist of apisix configurations. If you have any specific questions feel free to ask and the community will help.

Hi @MariaLapovska, are you still working on this PR?

@Baoyuantop yes - I'll add tests, and I've created an issue detailing this feature, but there's no discussion in it

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.