feat: extend chaitin-waf plugin functionalities #9945#12029
Merged
Conversation
AlyHKafoury
commented
Mar 10, 2025
AlyHKafoury
marked this pull request as ready for review
March 10, 2025 16:48
dosubot
Bot
added
size:L
AlyHKafoury
marked this pull request as draft
March 10, 2025 16:49
AlyHKafoury
marked this pull request as ready for review
March 10, 2025 17:15
dosubot
Bot
added
size:XL
Contributor
Author
|
@membphis I believe this is ready for review |
Contributor
Author
|
@moonming A gentle ping that this PR is ready for review |
Member
Cool, I will review your PR, thanks for your contribution |
Contributor
Author
|
I will Fix linting issues |
Baoyuantop
reviewed
Mar 12, 2025
Baoyuantop
left a comment
Baoyuantop
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution! There are some suggestions for improvement on the documents.
Co-authored-by: Baoyuan <[email protected]>
Co-authored-by: Baoyuan <[email protected]>
Co-authored-by: Baoyuan <[email protected]>
Contributor
Author
|
@Baoyuantop Thank you for your comments, I applied them |
Contributor
Can you help fix the failed CI? If it's unstable, let us know and we'll re-run it. |
Contributor
Author
|
It is unstable I only accepted the documentation changes, please rerun the
failed items on the CI
Best Regards,
Aly Kafoury
…On Wed, Mar 12, 2025, 12:06 PM Baoyuan ***@***.***> wrote:
@Baoyuantop <https://github.com/Baoyuantop> Thank you for your comments,
I applied them
Can you help fix the failed CI? If it's unstable, let us know and we'll
re-run it.
—
Reply to this email directly, view it on GitHub
<#12029 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKUBD3HCPUR45P5OPCGPWT2UABK7AVCNFSM6AAAAABYUVBUHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJXGMZTANBUGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: Baoyuantop]*Baoyuantop* left a comment (apache/apisix#12029)
<#12029 (comment)>
@Baoyuantop <https://github.com/Baoyuantop> Thank you for your comments,
I applied them
Can you help fix the failed CI? If it's unstable, let us know and we'll
re-run it.
—
Reply to this email directly, view it on GitHub
<#12029 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKUBD3HCPUR45P5OPCGPWT2UABK7AVCNFSM6AAAAABYUVBUHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJXGMZTANBUGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
|
@Baoyuantop A gentle reminder |
Baoyuantop
previously approved these changes
Mar 13, 2025
Baoyuantop
left a comment
Baoyuantop
left a comment
Contributor
There was a problem hiding this comment.
LGTM, waiting for others to review
moonming
previously approved these changes
Mar 19, 2025
AlinsRan
reviewed
Mar 19, 2025
Co-authored-by: AlinsRan <[email protected]>
Contributor
Author
|
@AlinsRan @Baoyuantop @moonming @membphis I completed the latest requested changes, and the tests pass locally so please review and help run the CI tests |
Contributor
Author
|
This CI fail run is unstable, please restart the failed job |
AlinsRan
approved these changes
Mar 24, 2025
Contributor
|
cc @membphis help review |
moonming
approved these changes
Mar 25, 2025
nic-6443
reviewed
Mar 27, 2025
Comment on lines
+57
to
+58
| enum = { "off", "monitor", "block", nil }, | ||
| default = nil, |
Member
There was a problem hiding this comment.
We don't need to explicitly specify nil in enum and default value. When this field is not declared as required in the JSON schema, it can be nil, and the default value is also nil.
Contributor
There was a problem hiding this comment.
This does not affect the use of this feature, which is merged first and then an issue is created to track it.
nic-6443
reviewed
Mar 27, 2025
Comment on lines
+103
to
+104
| enum = { "off", "monitor", "block", nil }, | ||
| default = nil, |
Baoyuantop
approved these changes
Mar 28, 2025
github-project-automation
Bot
moved this from 👀 In review
to ✅ Done
in ⚡️ Apache APISIX Roadmap
5 tasks
laz-xyr
pushed a commit
to laz-xyr/apisix
that referenced
this pull request
Jun 19, 2025
…2029) Co-authored-by: AlinsRan <[email protected]>
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed #9945
Checklist