fix: resync etcd when a lower revision is found#12015
Merged
Merged
Conversation
dosubot
Bot
added
size:S
membphis
reviewed
Mar 3, 2025
dosubot
Bot
added
size:L
nic-chen
reviewed
Mar 5, 2025
| cancel_watch(http_cli) | ||
| break | ||
| end | ||
| watch_ctx.rev = rev + 1 |
Member
There was a problem hiding this comment.
what will happen when rev == watch_ctx.rev ?
Contributor
Author
There was a problem hiding this comment.
updated the code.
- Smaller revision -> Cause resync
- Equal revision -> Do nothing like previous
- Bigger revision -> Increment watch_ctx.rev
dosubot
Bot
added
size:S
nic-chen
approved these changes
Mar 5, 2025
membphis
approved these changes
Mar 5, 2025
nic-6443
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
When using ingress controller in etcd mode, if the ingress restarts the revision in etcd will start over since its stateless.
APISIX on receiving updates ignores the lower revision. This PR makes sure that a full resync is triggered when lower revision is found.
Checklist