Skip to content

fix(ai-proxy): remove model options' stream default value#12013

Merged
shreemaan-abhishek merged 3 commits into
apache:masterfrom
shreemaan-abhishek:fix-ai-proxy-stream
Mar 3, 2025
Merged

fix(ai-proxy): remove model options' stream default value#12013
shreemaan-abhishek merged 3 commits into
apache:masterfrom
shreemaan-abhishek:fix-ai-proxy-stream

Conversation

@shreemaan-abhishek

@shreemaan-abhishek shreemaan-abhishek commented Mar 1, 2025

Copy link
Copy Markdown
Contributor

Description

Passing stream option in request body has no effect as it is overridden by default value in the schema. If I want to support stream mode, I need specify stream option in plugin configuration explicitly, which is a bad UX.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working plugin labels Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working plugin size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants