refactor: ai-content-moderation to ai-aws-content-moderation#12010
Merged
shreemaan-abhishek merged 7 commits intoMar 6, 2025
Merged
Conversation
dosubot
Bot
added
size:L
Member
|
CI failed, pls fix those first |
Contributor
Author
seems like flaky error, I have re-run the CI. |
membphis
approved these changes
Mar 5, 2025
Member
|
ci failed |
Revolyssup
approved these changes
Mar 5, 2025
nic-6443
approved these changes
Mar 6, 2025
kayx23
reviewed
Mar 7, 2025
| | comprehend.secret_access_key | Yes | String | AWS secret access key | | ||
| | comprehend.region | Yes | String | AWS region | | ||
| | comprehend.endpoint | No | String | AWS Comprehend service endpoint. Must match the pattern `^https?://` | | ||
| | comprehend.ssl_verify | No | String | Enables SSL certificate verification. | |
Member
There was a problem hiding this comment.
Missing default value column. e.g. ssl_verify default is true.
laz-xyr
pushed a commit
to laz-xyr/apisix
that referenced
this pull request
Jun 19, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current plug-in configuration abstraction turned out to be a bad design choice as the moderation mechanism is hard-coded to plugin logic, if we use other AI content moderation services, there will be huge differences in how the content moderation is done.
So, this PR refactors
ai-content-moderationplugin by making it specific forai-aws-content-moderation.Checklist