feat: set default value of ssl_trusted_certificate to system#11993
Merged
bzp2010 merged 36 commits intoMar 11, 2025
Conversation
nic-6443
previously approved these changes
Feb 25, 2025
system
systemssl_trusted_certificate to system
shreemaan-abhishek
previously approved these changes
Feb 25, 2025
nic-6443
previously approved these changes
Feb 25, 2025
Revolyssup
dismissed stale reviews from nic-6443 and shreemaan-abhishek
via
February 25, 2025 08:23
58287b9
nic-6443
reviewed
Mar 7, 2025
nic-6443
approved these changes
Mar 7, 2025
membphis
approved these changes
Mar 10, 2025
bzp2010
approved these changes
Mar 11, 2025
5 tasks
laz-xyr
pushed a commit
to laz-xyr/apisix
that referenced
this pull request
Jun 19, 2025
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When testing AI plugins, we found that
ssl_trusted_certificateshould be set tosystem, otherwise APISIX will continuously report errors when accessing external AI services.Further refactoring:
Currently two ways are used for reading configuration.
The problem - Schema validation for configuration happens only in local_conf so at startup, the local conf schema is not validated. This is an inconsistency.
This is especially problematic when my change uses schema to set the default to "system" because this default is only set during lifecycle and not during generation of nginx.conf.
This PR moves the schema validation inside read_yaml_conf for consistency. Now local_conf is just calling read_yaml_conf internally and adding cache.
Effect on PR of refactoring
This makes sure that consistently at all places when yaml file is read, first schema validation happens which sets the default value of trusted certificate to "system" and then later the overrides take place including the one which replaces "system" with cert paths.
Based on the discussion below, this PR also removes support for combining multiple certs
Fixes # (issue)
Checklist
Fixes #11720