Skip to content

perf: replace 'string.find' with 'core.string.find'#11886

Merged
membphis merged 2 commits into
apache:masterfrom
xuruidong:patch-1
Feb 5, 2025
Merged

perf: replace 'string.find' with 'core.string.find'#11886
membphis merged 2 commits into
apache:masterfrom
xuruidong:patch-1

Conversation

@xuruidong

Copy link
Copy Markdown
Contributor

Description

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. performance generate flamegraph for the current PR labels Jan 4, 2025
@juzhiyuan
juzhiyuan requested a review from membphis January 5, 2025 12:32
@Revolyssup
Revolyssup self-requested a review January 28, 2025 18:04

@membphis membphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^_^

@membphis
membphis merged commit 100f290 into apache:master Feb 5, 2025
@membphis

membphis commented Feb 5, 2025

Copy link
Copy Markdown
Member

merged, many thx @xuruidong

@xuruidong
xuruidong deleted the patch-1 branch February 5, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance generate flamegraph for the current PR size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants