fix(ai-proxy): query params in override.endpoint not being sent to LLMs#11863
Merged
shreemaan-abhishek merged 3 commits intoDec 30, 2024
Merged
Conversation
Revolyssup
approved these changes
Dec 26, 2024
membphis
approved these changes
Dec 30, 2024
nic-6443
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Although the
ai-proxyplugin officially supports onlyopenaias an LLM provider, the plugin can be used to proxy requests to azure-openai service as mentioned in this blog: https://docs.api7.ai/apisix/how-to-guide/ai-gateway/proxy-azure-openai-requests, by entering the correct URL inoverride.endpointattribute ofai-proxy.However, the
azure-openaideployment URL contains some query params that wasn't being carried into the request (HTTP request made byai-proxyplugin) to the LLM endpoint. This PR ensures that query params inoverride.endpointare appropriately used.Checklist