refactor: workflow plugin registration#11832
Merged
Revolyssup merged 2 commits intoDec 17, 2024
Merged
Conversation
dosubot
Bot
added
size:M
membphis
reviewed
Dec 16, 2024
membphis
left a comment
membphis
left a comment
Member
There was a problem hiding this comment.
do we need to add any new test cases?
Contributor
Author
This is just a refactor. Functionality is already covered in existing test cases. This is internal logic change. So I dont think test cases are needed |
membphis
approved these changes
Dec 17, 2024
shreemaan-abhishek
approved these changes
Dec 17, 2024
nic-6443
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Current logic requires the table
supported_actionsdefined in workflow.lua to be changed when any new plugin is added to the workflow plugin. With this change, the registration in the table is offloaded to the newly added plugin by implementing the function workflow_handler()Checklist