feat: support _meta.pre_function to execute custom logic before execution of each phase#11793
Merged
Merged
Conversation
…tion of each phase
dosubot
Bot
added
size:L
Revolyssup
changed the title
nic-6443
previously approved these changes
Dec 3, 2024
Member
|
@Revolyssup some CI test cases failed 
|
dosubot
Bot
added
size:XL
Revolyssup
commented
Dec 24, 2024
| |os|print|tonumber|math|pcall|xpcall|unpack | ||
| |pairs|ipairs|assert|module|package | ||
| |coroutine|[gs]etfenv|next|rawget|rawset | ||
| |loadstring|dofile|collectgarbage|load |
Contributor
Author
There was a problem hiding this comment.
load is added here which is not present in original lj-relang causing lint check to fail
membphis
reviewed
Dec 24, 2024
| @@ -0,0 +1,228 @@ | |||
| #!/usr/bin/env perl | |||
Member
There was a problem hiding this comment.
can we update the tool utils/lj-releng in a separate PR?
one PR for one thing
small PR is easier to review
Contributor
Author
5 tasks
| local local_plugins = core.table.new(32, 0) | ||
| local tostring = tostring | ||
| local error = error | ||
| -- make linter happy to avoid error: getting the Lua global "load" |
Contributor
There was a problem hiding this comment.
I guess this is no longer needed?
Contributor
Author
There was a problem hiding this comment.
This is needed. The lj-releng file just added to the keywords that can be used with the ignore comment.
dosubot
Bot
added
size:L
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
moonming
approved these changes
Jan 21, 2025
shreemaan-abhishek
approved these changes
Jan 21, 2025
membphis
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pre_function to the meta of the plugin to allow some personalized code to run before all plugins run. For example, register personalized variables so that these temporary variables can be referenced and used in the plugin.
Description
Fixes # (issue)
Add pre_function to the meta of the plugin to allow some personalized code to run before all plugins run. For example, register personalized variables so that these temporary variables can be referenced and used in the plugin.
Checklist