feat: plugins in multi-auth returns error instead of logging it#11775
Merged
shreemaan-abhishek merged 8 commits intoNov 27, 2024
Merged
Conversation
moonming
approved these changes
Nov 26, 2024
nic-6443
approved these changes
Nov 26, 2024
Revolyssup
approved these changes
Nov 27, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using auth plugins with the multi auth plugin, if one of the authentication fails but other auth plugins succeed, the basic auth plugin will record a warning log, causing inconvenience to the user.
apisix/apisix/plugins/multi-auth.lua at master · apache/apisix The muti auth plugin does not record the error message returned by the plugin.
Solution:
When there are multiple plugins in muti auth, if the final verification is passed (that is, any plugin is verified), even if other plugins return errors, no error log needs to be recorded
If all plugins fail to verify, summarize the error messages of multiple plugins into a log for recording.
Checklist