feat(jwt-auth): support configuring key_claim_name#11772
Merged
shreemaan-abhishek merged 7 commits intoNov 27, 2024
Merged
Conversation
dosubot
Bot
added
size:L
Revolyssup
self-requested a review
November 22, 2024 07:38
Revolyssup
previously approved these changes
Nov 22, 2024
5 tasks
membphis
reviewed
Nov 25, 2024
membphis
left a comment
membphis
left a comment
Member
There was a problem hiding this comment.
need to update the doc at same time
Revolyssup
previously approved these changes
Nov 25, 2024
nic-6443
previously approved these changes
Nov 25, 2024
membphis
reviewed
Nov 25, 2024
| } | ||
| }, | ||
| key_claim_name = { | ||
| type = "string", |
Member
There was a problem hiding this comment.
Add a limitation about the length, the minimum length should be 1
empty string isn’t acceptable
shreemaan-abhishek
dismissed stale reviews from nic-6443 and Revolyssup
via
November 25, 2024 06:46
10d83e3
membphis
reviewed
Nov 25, 2024
| key_claim_name = { | ||
| type = "string", | ||
| default = "key", | ||
| minLength = "1", |
Member
There was a problem hiding this comment.
this wrong, we should use minLength = 1, it should be a number
membphis
approved these changes
Nov 26, 2024
nic-6443
approved these changes
Nov 27, 2024
Revolyssup
self-requested a review
November 27, 2024 06:48
Revolyssup
approved these changes
Nov 27, 2024
Contributor
|
This PR fixed #11276 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support configuring key_claim_name like kong: https://docs.konghq.com/hub/kong-inc/jwt/configuration/#config-key_claim_name
Checklist