feat(body-transformer): support mulipart content-type#11767
Merged
Revolyssup merged 7 commits intoNov 29, 2024
Conversation
dosubot
Bot
added
size:L
…port-multipart-content
shreemaan-abhishek
previously approved these changes
Nov 22, 2024
shreemaan-abhishek
previously approved these changes
Nov 22, 2024
Contributor
Author
|
@membphis can you review this? |
membphis
previously approved these changes
Nov 25, 2024
membphis
left a comment
membphis
left a comment
Member
There was a problem hiding this comment.
LGTM, except one minor thing
| conf[typ].input_format = "json" | ||
| elseif str_find(ct:lower(), "application/x-www-form-urlencoded", nil, true) then | ||
| conf[typ].input_format = "encoded" | ||
| elseif str_find(ct:lower(), "multipart/", nil) then |
Member
There was a problem hiding this comment.
performance: we should enable plain mode
Revolyssup
commented
Nov 25, 2024
Revolyssup
dismissed stale reviews from membphis and shreemaan-abhishek
via
November 25, 2024 09:20
e374a62
membphis
approved these changes
Nov 25, 2024
shreemaan-abhishek
approved these changes
Nov 25, 2024
moonming
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
multipartcontent-type in body-transformer plugin.Fixes # (issue)
Checklist