fix(ai-proxy): missing parsed_url nil check#11637
Merged
shreemaan-abhishek merged 4 commits intoDec 16, 2024
Merged
Conversation
This reverts commit eab5f6f.
shreemaan-abhishek
marked this pull request as ready for review
November 5, 2024 04:11
dosubot
Bot
added
size:M
moonming
approved these changes
Dec 13, 2024
nic-6443
approved these changes
Dec 14, 2024
Revolyssup
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ai-proxy plugin code had missing nil check for
parsed_url. This bug remained undetected by the test cases as all test cases use valid override.endpoint. While developing the plugin, this bug remained undeteced by me too because I was using self hosted openai server.Fixes # (issue)
Checklist