feat(splunk-logger): allow configuring keepalive_timeout#11611
Merged
shreemaan-abhishek merged 3 commits intoSep 30, 2024
Conversation
dosubot
Bot
added
size:XS
shreemaan-abhishek
requested review from
Revolyssup,
membphis,
moonming and
nic-6443
September 26, 2024 11:52
moonming
previously approved these changes
Sep 26, 2024
nic-6443
previously approved these changes
Sep 27, 2024
Revolyssup
previously approved these changes
Sep 27, 2024
membphis
requested changes
Sep 27, 2024
membphis
left a comment
membphis
left a comment
Member
There was a problem hiding this comment.
need some test case to confirm the changing
Contributor
Author
|
@membphis how to write test case for keepalive timeout? |
shreemaan-abhishek
dismissed stale reviews from Revolyssup, nic-6443, and moonming
via
September 27, 2024 08:04
91d9c43
dosubot
Bot
added
size:M
membphis
approved these changes
Sep 29, 2024
moonming
approved these changes
Sep 30, 2024
Revolyssup
approved these changes
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default keepalive timeout is too long and will lead to lot of sockets left open in high scale.
Checklist