Skip to content

feat: implement credential#11601

Merged
moonming merged 12 commits into
apache:masterfrom
dspo:dspo/credentials
Sep 26, 2024
Merged

feat: implement credential#11601
moonming merged 12 commits into
apache:masterfrom
dspo:dspo/credentials

Conversation

@dspo

@dspo dspo commented Sep 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR add a resource named credential and implement Admin APIs for it.
Credential is used to hold the authentication credentials for the Consumer.
Credentials are used when multiple credentials need to be configured for a Consumer.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dspo
dspo marked this pull request as ready for review September 26, 2024 01:17
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Sep 26, 2024
nic-6443
nic-6443 previously approved these changes Sep 26, 2024
View reviewed changes
@nic-6443

nic-6443 commented Sep 26, 2024

Copy link
Copy Markdown
Member

@kayx23 Please help review the documentation part of this PR.

kayx23
kayx23 reviewed Sep 26, 2024
View reviewed changes
Comment thread docs/en/latest/admin-api.md Outdated
kayx23
kayx23 reviewed Sep 26, 2024
View reviewed changes
Comment thread docs/en/latest/admin-api.md Outdated
kayx23
kayx23 reviewed Sep 26, 2024
View reviewed changes
Comment thread docs/en/latest/terminology/credential.md Outdated
@moonming

moonming commented Sep 26, 2024

Copy link
Copy Markdown
Member

Is this a break change for using the authentication plugin on consumers?

@dspo

dspo commented Sep 26, 2024

Copy link
Copy Markdown
Contributor Author

Is this a break change for using the authentication plugin on consumers?

It's not a break change. Users can still use Consumer in the same way as before, and the one change to Consumer is that it is no longer required to have at least one auth plugin.

@dspo
dspo requested a review from kayx23 September 26, 2024 03:54
@kayx23

kayx23 commented Sep 26, 2024

Copy link
Copy Markdown
Member

@kayx23 Please help review the documentation part of this PR.

No additional comments from me for docs.

kayx23
kayx23 approved these changes Sep 26, 2024
View reviewed changes

@kayx23 kayx23 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc lgtm

@moonming
moonming merged commit 263143d into apache:master Sep 26, 2024
@shreemaan-abhishek shreemaan-abhishek mentioned this pull request Oct 8, 2024
Merged
5 tasks
This was referenced May 12, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nic-6443 nic-6443 nic-6443 approved these changes
@moonming moonming moonming approved these changes
@kayx23 kayx23 kayx23 approved these changes
@membphis membphis Awaiting requested review from membphis
@bzp2010 bzp2010 Awaiting requested review from bzp2010

Assignees

No one assigned

Labels

enhancement New feature or request size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dspo @nic-6443 @moonming @kayx23