feat: Jwt-auth plugin no longer requires a private_key to be uploaded.#11597
Merged
Conversation
dspo
changed the title
/apisix/plugin/jwt/sign
dspo
marked this pull request as ready for review
September 24, 2024 04:12
dosubot
Bot
added
size:XXL
dspo
marked this pull request as draft
September 24, 2024 06:00
nic-6443
reviewed
Sep 24, 2024
nic-6443
reviewed
Sep 24, 2024
dspo
changed the title
/apisix/plugin/jwt/sign/apisix/plugin/jwt/sign
dspo
marked this pull request as ready for review
September 25, 2024 01:13
dspo
changed the title
/apisix/plugin/jwt/sign
nic-6443
previously approved these changes
Sep 25, 2024
nic-6443
reviewed
Sep 25, 2024
Co-authored-by: Nic <[email protected]>
membphis
reviewed
Sep 25, 2024
moonming
requested changes
Sep 25, 2024
moonming
reviewed
Sep 25, 2024
…ird-party tool to generate them if you don't have to.
moonming
requested changes
Sep 26, 2024
Contributor
Author
moonming
approved these changes
Sep 27, 2024
nic-6443
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For security reasons, the API gateway should not accept uploads of users' private keys for issuing jwt tokens, and should no longer provide an API for issuing jwt tokens.
This PR removes the
/apisix/plugin/jwt/signAPI.Checklist