Currently only supports the upstream dynamically specify the cache time. If the upstream does not specify it such as the header Expires or Cache-Control, the cache_ttl in the config.yaml will be used. And the option hide_cache_headers will be decide whether the upstream header Expires and Cache-Control is sent to the client.
It's just a trick. Hopefully it can be easily understand.
Thanks.

how to add test cases for this plugin?

Hi @moonming

Tests cases I think the t/servroot/conf/nginx.conf file should be modified.

In recent days, i have been preparing to make a presentation. So I'm gonna add tests in this weekend.
And are there any other problems with code implementation?
Thanks.

How about the new style? I think the new style is simpler.

# current style
"proxy-cache": {
    "cache_key": ["$uri"]
    "cache_bypass": ["$arg_bypass"],
    ... ...
}

# new style
"proxy-cache": {
    "cache_key": ["uri"]
    "cache_bypass": ["arg_bypass"],
    ... ...
}

And I have other new questions:

1. need some e2e test case
2. need a way to purge the old cache

How about the new style? I think the new style is simpler.

# current style
"proxy-cache": {
    "cache_key": ["$uri"]
    "cache_bypass": ["$arg_bypass"],
    ... ...
}

# new style
"proxy-cache": {
    "cache_key": ["uri"]
    "cache_bypass": ["arg_bypass"],
    ... ...
}

Here can use variables or strings, so need an identifier to distinguish it.

And I have other new questions:

1. need some e2e test case
2. need a way to purge the old cache

I'm also considering these things. For 2 if there is no better solution, cache purge script will be the final choice.

And I have other new questions:

1. need some e2e test case
2. need a way to purge the old cache

1. e2e test cases I haven't figured it out yet. Do you have any suggestions?
2. Added. Users only need to specify the method=PURGE to delete cache file. Please review it.

Thanks.

https://github.com/apache/incubator-apisix/pull/1153/files/56a1f42fd1e8bd30575856758a51e8a21acf2e4c..b3ccdb372520e2849871afe017591a148be4664c#diff-df639fd03e25e10ae720a3ccd80a9430R187

that is cool.

And I have other new questions:

1. need some e2e test case
2. need a way to purge the old cache

1. e2e test cases I haven't figured it out yet. Do you have any suggestions?
2. Added. Users only need to specify the method=PURGE to delete cache file. Please review it.

Thanks.

@moonming @membphis

Do you have any suggestions for the test cases?

Moreover, I think I should figure out the logic of the APISIX test cases.

Thanks.

Please review @moonming @membphis

LGTM. Need add this plugin to README.md.
@membphis please take a look about how to add test cases.

OK. I'll add it to README. Basically test cases are covered.

@membphis ping

@agile6v It seems that you have to rebase your branch, this branch has conflicted with master branch.

@agile6v It seems that you have to rebase your branch, this branch has conflicted with master branch.

Resolved.

LGTM, we can merge it after run the test cases.

merged, many thx @agile6v