feat: support gcp secret manager#11436
Merged
Merged
Conversation
soulbird
reviewed
Aug 5, 2024
dosubot
Bot
added
the
size:XXL
bzp2010
self-requested a review
September 4, 2024 07:40
bzp2010
reviewed
Sep 4, 2024
Contributor
|
Hi @kayx23 Please take a look at the documentation when you are free to see if there are any problems. 🫡 |
membphis
reviewed
Sep 4, 2024
kayx23
reviewed
Sep 7, 2024
membphis
reviewed
Sep 9, 2024
5 tasks
Contributor
Author
Contributor
|
@HuanXin-Chen There were some failures in CI involving traffic-split3.t, no worries, just merge the master branch into your dev branch |
Contributor
Author
|
@bzp2010 @membphis @soulbird @kayx23 @shreemaan-abhishek |
membphis
previously approved these changes
Sep 18, 2024
membphis
left a comment
membphis
left a comment
Member
There was a problem hiding this comment.
LGTM, I mainly check the code style, doc and test case
bzp2010
approved these changes
Sep 20, 2024
shreemaan-abhishek
approved these changes
Sep 20, 2024
Contributor
|
Great job 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Many enterprises are utilizing cloud services from AWS and GCP, relying on the secret manager provided by these platforms to handle sensitive information. Integrating Apache APISIX with these secret managers can streamline the process of using sensitive information within APISIX, enabling users to manage and utilize cloud-stored sensitive data more conveniently, thus enhancing the overall security and usability of the system.
This PR has completed the support for GCP. It added the gcp.lua file to the original secret module, allowing users to store their secret information on GCP using the same reference method as before.
Checklist