feat(secret): support store ssl.keys ssl.certs in secrets mamager#11339
Merged
Conversation
AlinsRan
marked this pull request as ready for review
June 7, 2024 03:16
AlinsRan
requested review from
Revolyssup,
moonming,
nic-6443 and
shreemaan-abhishek
June 7, 2024 03:40
moonming
reviewed
Jun 7, 2024
moonming
approved these changes
Jun 7, 2024
shreemaan-abhishek
approved these changes
Jun 11, 2024
nic-6443
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of #8319
Support for storing certificates and private_keys on ssl through Secret Manager.
It is known that both
certandkeysupport management through the Secret Manager, andkeysandcertsshould also support it.Checklist