feat: support hcv namespace#11277
Merged
Merged
Conversation
Contributor
Author
|
I noticed that a lint error has appeared in another document, it has nothing to do with the current PR, should I fix it here? |
shreemaan-abhishek
previously approved these changes
May 22, 2024
moonming
previously approved these changes
May 23, 2024
Contributor
Author
|
It looks like the code changes are fine, but the documentation changes still need to be checked by one of the main documentation maintainers:
|
Member
@kayx23 please take a look, thx |
Member
|
kayx23
reviewed
May 23, 2024
Contributor
Author
|
Since this PR modifies the Chinese |
kayx23
reviewed
May 23, 2024
kayx23
approved these changes
May 23, 2024
moonming
approved these changes
May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HashiCorp Cloud and Enterprise editions support multi-tenancy based on the namespace concept. By using a specific HTTP Header, we can get the key from a specific namespace.
This makes sense, for HashiCorp Cloud it looks like namespaces are turned on by default and its default namespace is admin, which will not work when the client (APISIX) does not specify a namespace.
This PR adds namespace support on HCV (HashiCorp Vault).
Addition
In addition to this, I would suggest to rename the
vaultmodule in APISIX tohcv, based on the fact thatvaultitself is a neutral term that stands for some kind of component used to store keys.HashiCorp Vaultis the name of that software, so it should be writtenhcvand notvault.I would suggest renaming it, and in the meantime, we could add some sort of aliasing mechanism to continue to support users who use
vaultuntil APISIX 4.0, when we can remove support for the old name.Checklist