Skip to content

fix: stream route matcher is nil after first match#11269

Merged
moonming merged 2 commits into
apache:masterfrom
nic-6443:nic/fix-stream-route
May 21, 2024
Merged

fix: stream route matcher is nil after first match#11269
moonming merged 2 commits into
apache:masterfrom
nic-6443:nic/fix-stream-route

Conversation

@nic-6443

@nic-6443 nic-6443 commented May 20, 2024

Copy link
Copy Markdown
Member

Description

Fix #11259

this bug introduced in https://github.com/apache/apisix/pull/10298/files#diff-0234dd467ed66c3dffbef844397e9e7e018c287aab324ba8dd0b5a9e03b89360, I have no idea why made those changes,
set route.value.xxx_matcher to nil is insane, the stream route only working in first matched request now, after first match, all requests to same stream route will be panic with nil matcher:
image
image

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

f
Signed-off-by: Nic <[email protected]>
@moonming
moonming merged commit e193439 into apache:master May 21, 2024
@nic-6443
nic-6443 deleted the nic/fix-stream-route branch May 21, 2024 04:40
@bzp2010 bzp2010 added the bug Something isn't working label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

3 participants