fix(secret): rectify the way to fetch secret resource by id#11164
Merged
shreemaan-abhishek merged 2 commits intoApr 25, 2024
Merged
Conversation
starsz
approved these changes
Apr 22, 2024
starsz
self-requested a review
April 22, 2024 07:06
soulbird
approved these changes
Apr 23, 2024
moonming
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of caching the secrets resource and iterating over all of them in a loop to find the correct secret resource, it's better to directly use the
getfunction. This also maintains consistency with other parts of the apisix code.Fixes # (issue)
Checklist