fix(kafka-pubsub): restore pb.state appropriately#11135
Merged
shreemaan-abhishek merged 4 commits intoApr 10, 2024
Conversation
shreemaan-abhishek
marked this pull request as ready for review
April 10, 2024 03:16
bzp2010
approved these changes
Apr 10, 2024
bzp2010
reviewed
Apr 10, 2024
| local pb_old_state = pb.state(pb_state) | ||
|
|
||
| -- only recover state if it has changed | ||
| if pb.state() ~= pb_state then |
Contributor
There was a problem hiding this comment.
It is a good idea to add a check to make sure that the same pb.state is indeed equal. i.e. verifying that == can indeed be used to check for equality.
I'm concerned that this behavior may be broken by updates to openresty and luajit.
Contributor
Author
There was a problem hiding this comment.
we can deal with that later.
starsz
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pb state should be restored before doing operations like
pb.encode()as the state might have been changed/polluted by code in other places that use the pb module.Fixes #10938
Checklist