Skip to content

fix(request.header): core.request.header return string instead of table#11127

Merged
moonming merged 3 commits into
apache:masterfrom
ronething:fix/request_header_master
Apr 8, 2024
Merged

fix(request.header): core.request.header return string instead of table#11127
moonming merged 3 commits into
apache:masterfrom
ronething:fix/request_header_master

Conversation

@ronething

@ronething ronething commented Apr 8, 2024

Copy link
Copy Markdown
Member

Signed-off-by: ashing [email protected]

Description

Fixes #11126

In order to prevent the caller from judging the data type by itself.

notice: After core.request.header function changed, we need to get original header value by using core.request.headers in file real-ip.lua and ua-restriction.lua

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@ronething

Copy link
Copy Markdown
Member Author

@moonming please take a look at this PR when you have time, thanks.

@moonming
moonming merged commit e36db17 into apache:master Apr 8, 2024
@ronething
ronething deleted the fix/request_header_master branch April 8, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: hmac-auth plugin will cause error when use duplicate signature header

3 participants