Skip to content

fix(ci): free disk space#11081

Merged
starsz merged 2 commits into
apache:masterfrom
walter-mo:fix-ci
Mar 28, 2024
Merged

fix(ci): free disk space#11081
starsz merged 2 commits into
apache:masterfrom
walter-mo:fix-ci

Conversation

@walter-mo

@walter-mo walter-mo commented Mar 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes # (bug(ci): ci failing due to incomplete docker image backup)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@shreemaan-abhishek

shreemaan-abhishek commented Mar 22, 2024

Copy link
Copy Markdown
Contributor

The github action you added won't work: https://github.com/apache/apisix/actions/runs/8389436022

@walter-mo

walter-mo commented Mar 22, 2024

Copy link
Copy Markdown
Contributor Author

@shreemaan-abhishek need an approval for workflows.

@walter-mo

walter-mo commented Mar 22, 2024

Copy link
Copy Markdown
Contributor Author

How can I pass the test? https://github.com/apache/apisix/actions/runs/8390349306/job/22978748114?pr=11081#step:17:279.

@shreemaan-abhishek

shreemaan-abhishek commented Mar 22, 2024

Copy link
Copy Markdown
Contributor

@motongxue it looks like a flaky failure. I have re-ran that workflow.

Could you please take care of the following as well?
image

@shreemaan-abhishek shreemaan-abhishek linked an issue Mar 23, 2024 that may be closed by this pull request
bug(ci): ci failing due to incomplete docker image backup #11068
Closed
@zll600

zll600 commented Mar 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@motongxue it looks like a flaky failure. I have re-ran that workflow.

Could you please take care of the following as well? image

If the GHE runner's disk is not enough, the step save docker images will always fail(no space left on device). Then the cache in CI will make no sence. So I think free disk space is a better approach.

@walter-mo

walter-mo commented Mar 25, 2024

Copy link
Copy Markdown
Contributor Author

@motongxue it looks like a flaky failure. I have re-ran that workflow.
Could you please take care of the following as well? image

If the GHE runner's disk is not enough, the step save docker images will always fail(no space left on device). So the cache in CI will make no sence. So I think free disk space is a better approach.

I think so.

starsz
starsz previously approved these changes Mar 26, 2024
View reviewed changes
shreemaan-abhishek
shreemaan-abhishek requested changes Mar 27, 2024
View reviewed changes
Comment thread ci/free_disk_space.sh Outdated
@walter-mo
walter-mo requested a review from starsz March 27, 2024 03:26
@starsz
starsz merged commit 71ad87d into apache:master Mar 28, 2024
@LiteSun LiteSun mentioned this pull request Jun 11, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starsz starsz starsz approved these changes
@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(ci): ci failing due to incomplete docker image backup

4 participants

@walter-mo @shreemaan-abhishek @zll600 @starsz