feat: enable sensitive fields encryption by default#11076
Conversation
|
I presume test cases are not needed. EDIT: A lot of test cases are failing so it might be the case that we actually need to add test cases. |
|
If a user upgrades APISIX from an old version to a new version, will this configuration be updated? Expected behavior is to not update |
By default |
Got it, so it's a break change |
| enable_data_encryption = | ||
| core.table.try_read_attr(local_conf, "apisix", "data_encryption", | ||
| "enable_encrypt_fields") | ||
| "enable_encrypt_fields") and (core.config.type == "etcd") |
There was a problem hiding this comment.
encrypt fields only when config type is etcd. Without this addition, enabling encrypt_fields on standalone mode would cause unexpected failures.
| "plugins": { | ||
| "key-auth": { | ||
| "key": "auth-one" | ||
| "key": "4y+JvURBE6ZwRbbgaryrhg==" |
There was a problem hiding this comment.
since data encryption is true now, the body returned after a PUT operation would consist of encrypted information.
3 participants
Description
Fixes https://lists.apache.org/thread/30wf080qvrzokronrx283sy8x8kondqf
Checklist