fix: keep proxy-cache different strategy response header consistency#11048
Merged
juststillthinking merged 13 commits intoMar 18, 2024
Merged
Conversation
juststillthinking
approved these changes
Mar 15, 2024
Revolyssup
requested changes
Mar 18, 2024
| if err ~= "not found" then | ||
| if err == "expired" then | ||
| core.response.set_header("Apisix-Cache-Status", "EXPIRED") | ||
|
|
Contributor
There was a problem hiding this comment.
Can you remove these empty lines?
Contributor
Author
There was a problem hiding this comment.
I decided to write this after seeing the example of CODE_STYLE.
blank-line
Revolyssup
self-requested a review
March 18, 2024 06:22
Revolyssup
approved these changes
Mar 18, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11045
keep proxy-cache different strategy response header consistency
Checklist