fix(schema): the port value greater than 65535 should not be allowed#11043
Merged
Conversation
Contributor
|
@xuruidong Can you add a test case for this? Some test where you show that passing a port of higher number fails schema validation. |
xuruidong
marked this pull request as draft
March 15, 2024 07:55
Signed-off-by: xuruidong <[email protected]>
xuruidong
marked this pull request as ready for review
March 19, 2024 08:09
Signed-off-by: xuruidong <[email protected]>
Contributor
shreemaan-abhishek
approved these changes
Mar 21, 2024
Revolyssup
approved these changes
Mar 21, 2024
moonming
approved these changes
Mar 21, 2024
shreemaan-abhishek
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Checklist