Skip to content

refactor(http3): enable http3 directive only in http3 CI#11027

Merged
moonming merged 2 commits into
apache:masterfrom
zll600:h3_ci
Mar 14, 2024
Merged

refactor(http3): enable http3 directive only in http3 CI#11027
moonming merged 2 commits into
apache:masterfrom
zll600:h3_ci

Conversation

@zll600

@zll600 zll600 commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

Description

In #10989 and #11010, APISIX already supports configuring HTTP/3 and supports HTTP/3 CI. This PR want to refactor the CI to make sure that all test cases of APISIX work correctly with enable_http3 and disable_http3.

Test framework of APISIX depends on apisix-runtime which is build with nginx ngx_http_v3_module. And the http3 directive of nginx is on by default.

For build.yml, it will use APISIX.pm with http3 off for test cases. All test cases will run without http3.

        listen 1994 quic reuseport;
        listen 1994 ssl;
        http2 on;
        # disable http3 for test cases
        http3 off;
        ssl_certificate             cert/apisix.crt;
        ssl_certificate_key         cert/apisix.key;
        lua_ssl_trusted_certificate cert/apisix.crt;

For http3.yml, it will use APISIX.pm with http3 on for test cases. All test cases, including those unique to http3 which locate in t/http3/ will be run with http3 on.

        listen 1994 quic reuseport;
        listen 1994 ssl;
        http2 on;
        # enable http3 for test cases including test cases which only useful for http3
        http3 on;
        ssl_certificate             cert/apisix.crt;
        ssl_certificate_key         cert/apisix.key;
        lua_ssl_trusted_certificate cert/apisix.crt;

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@zll600
zll600 marked this pull request as ready for review March 13, 2024 04:54
Comment thread .github/workflows/http3.yml Outdated
@moonming
moonming merged commit ee2a759 into apache:master Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants