fix: revert "fix: the leak of prometheus metrics"#11025
Merged
shreemaan-abhishek merged 1 commit intoMar 13, 2024
Conversation
This reverts commit 59a6be4.
Revolyssup
approved these changes
Mar 12, 2024
starsz
approved these changes
Mar 13, 2024
shreemaan-abhishek
deleted the
revert-10655-guohao/fix-health-target-leak
branch
March 13, 2024 04:04
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #10655 as this PR introduced
metrics.upstream_status: reset()operation which causes a large number of shared memory read operations (in large scale deployments), resulting in CPU exceptions.